Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEZ-4267: Remove Superfluous Code from DAGAppMaster #90

Merged
merged 3 commits into from Jun 30, 2021
Merged

TEZ-4267: Remove Superfluous Code from DAGAppMaster #90

merged 3 commits into from Jun 30, 2021

Conversation

belugabehr
Copy link
Contributor

No description provided.

belugabehr
belugabehr commented Jan 24, 2021
View reviewed changes
tez-dag/src/main/java/org/apache/tez/dag/app/DAGAppMaster.java
@@ -2269,15 +2261,6 @@ public void handle(VertexEvent event) {
}
}

private static void validateInputParam(String value, String param)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only used in one place. Limited value,

belugabehr
belugabehr commented Jan 24, 2021
View reviewed changes
tez-dag/src/main/java/org/apache/tez/dag/app/DAGAppMaster.java
@@ -313,7 +311,6 @@
/**
* set of already executed dag names.
*/
Set<String> dagNames = new HashSet<String>();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No references to this variable anywhere

@belugabehr belugabehr closed this Jun 30, 2021
@belugabehr belugabehr reopened this Jun 30, 2021
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 33s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚 mvninstall 12m 18s master passed
+1 💚 compile 0m 44s master passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 compile 0m 33s master passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 checkstyle 1m 11s master passed
+1 💚 javadoc 0m 44s master passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javadoc 0m 32s master passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+0 🆗 spotbugs 1m 41s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 1m 40s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 0m 26s the patch passed
+1 💚 compile 0m 30s the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javac 0m 30s the patch passed
+1 💚 compile 0m 24s the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 javac 0m 24s the patch passed
+1 💚 checkstyle 0m 18s tez-dag: The patch generated 0 new + 53 unchanged - 1 fixed = 53 total (was 54)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 javadoc 0m 22s the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javadoc 0m 21s the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 findbugs 1m 8s the patch passed
_ Other Tests _
+1 💚 unit 4m 18s tez-dag in the patch passed.
+1 💚 asflicense 0m 14s The patch does not generate ASF License warnings.
27m 11s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-90/4/artifact/out/Dockerfile
GITHUB PR #90
JIRA Issue TEZ-4267
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
uname Linux 5a1ec7ed26ad 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/tez.sh
git revision master / 4684d06
Default Java Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-90/4/testReport/
Max. process+thread count 188 (vs. ulimit of 5500)
modules C: tez-dag U: tez-dag
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-90/4/console
versions git=2.25.1 maven=3.6.3 findbugs=3.0.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@jteagles jteagles merged commit 47a59ab into apache:master Jun 30, 2021
asfgit pushed a commit that referenced this pull request Jun 30, 2021
@belugabehr
TEZ-4267: Remove Superfluous Code from DAGAppMaster (#90)
b7b6436 
* TEZ-4267: Remove Superfluous Code from DAGAppMaster

* Remove superfluous variable

* Remove superfluous comment

Co-authored-by: David Mollitor <david.mollitor@cloudera.com>
(cherry picked from commit 47a59ab)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jteagles jteagles jteagles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@belugabehr @hadoop-yetus @jteagles