New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix(deployment): Fix probe paths #10

Merged

lewismc merged 1 commit into apache:main from stijnbrouwers:bugfix/probe-path

Mar 10, 2023

Contributor

stijnbrouwers commented Mar 6, 2023

I did the following changes:

Changed .Values.config.base_url: When it's not a proper URL, the urlParse function will give back wrong values for .path
Removed the "/" at the end of the probe paths, since the path return by urlParse is correct on it's own
Added an {{else}} clause in the probe path to catch the case when no base_url is provided.

For me, this setup seems to work.


          bugfix(deployment): Fix probe paths

338492f

lewismc approved these changes

View reviewed changes

Member

lewismc left a comment

+1 thanks @stijnbrouwers

lewismc merged commit 4e5b6cd into apache:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment