Fixes a bug with the order of HPA resources in ArgoCD #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is actually a bug in ArgoCD that is worked around by this. However, it's easier to do the change here and it has no further impact in this chart since Kubernetes doesn't care about the order. See original error: kubernetes/kubernetes#74099
|
Hi @stijnbrouwers it looks like the issue is going through a cycle of being stale then being reopened. I'll merge your PR. Thanks for yur patience. I was away from the project for a while. |
|
@lewismc no problem, thank you for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is actually a bug in ArgoCD that is worked around by this.
However, it's easier to do the change here and it has no further impact in this chart since Kubernetes doesn't care about the order.
See original error:
kubernetes/kubernetes#74099