Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid yaml document when helm lint is executed #8

Merged
merged 1 commit into from
Feb 15, 2023
Merged

Fix invalid yaml document when helm lint is executed #8

merged 1 commit into from
Feb 15, 2023

Conversation

frascu
Copy link
Contributor

@frascu frascu commented Feb 8, 2023

Error

Executing helm lint . the following message is printed:

[ERROR] templates/serviceaccount.yaml: unable to parse YAML: invalid Yaml document separator: apiVersion: v1

Error: 1 chart(s) linted, 1 chart(s) failed

Fix

Removing the dash in the file templates/serviceaccount.yaml, helm lint . works.
See here:

Env

helm version:
version.BuildInfo{Version:"v3.11.0", GitCommit:"472c5736ab01133de504a826bd9ee12cbe4e7904", GitTreeState:"clean", GoVersion:"go1.19.5"}

@frascu
Copy link
Contributor Author

frascu commented Feb 15, 2023

Hi @lewismc
Could you please review this pull request?
I need a minor version of tika-helm to fix the issue.

Copy link
Member

@lewismc lewismc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 verified to lint perfectly and operate locally on K3D.

@lewismc
Copy link
Member

lewismc commented Feb 15, 2023

Thanks for your patience @frascu

@lewismc lewismc merged commit f87ab01 into apache:main Feb 15, 2023
@lewismc
Copy link
Member

lewismc commented Feb 15, 2023

Should we release a new version of the Helm Chart?

@tballison
Copy link

+1 Note that we've slightly modified the docker numbering (e.g. 2.7.0.1 is the 1 docker release for Tika 2.7.0). We may want to do similar here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants