-
Notifications
You must be signed in to change notification settings - Fork 748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIKA-4119]: Return media type "text/javascript" instead of "application/javascript" to follow RFC-9239 #1556
[TIKA-4119]: Return media type "text/javascript" instead of "application/javascript" to follow RFC-9239 #1556
Conversation
5e7c9fe
to
31d26ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this looks great. As noted, there are a couple of changes that are unrelated to the goal of the PR. Thank you!
tika-core/src/test/java/org/apache/tika/mime/MimeTypesReaderTest.java
Outdated
Show resolved
Hide resolved
tika-core/src/test/java/org/apache/tika/mime/ProbabilisticMimeDetectionTest.java
Outdated
Show resolved
Hide resolved
…ion/javascript" Following RFC 9239. This also adds support for ".msj" ( as documented in the RFC).
31d26ab
to
4f14ca9
Compare
@tballison, thanks for the quick review. This should be in a better state now. |
Doh Something went wrong in the tests. |
Alright, it should be good now. At least all the tests passed twice when running on my machine. :-) |
Thank you, @marcospereira ! |
Thank you, @tballison. I see https://issues.apache.org/jira/browse/TIKA-4119 is still marked as "open". Is there something I need to do on my end or is it just out of sync with the changes here? |
What
Fixes TIKA-4119.
Additionally, I've added support for ".mjs" files, as documented in the RFC: