Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TIKA-3649 Perform findbugs static analysis on the project and address the issues #478

Merged
merged 3 commits into from
Jan 20, 2022
Merged

TIKA-3649 Perform findbugs static analysis on the project and address the issues #478

merged 3 commits into from
Jan 20, 2022

Conversation

dk2k
Copy link
Contributor

@dk2k dk2k commented Jan 6, 2022

Including changes in pom.xml for Findbugs
To get report use command: mvn clean compile site
and check the folder site in target.

@dk2k dk2k mentioned this pull request Jan 6, 2022
Closed
@lewismc
Copy link
Member

lewismc commented Jan 16, 2022

Hi @dk2k thanks for creating a PR 👍
I think the site report generation is obviously important!
I take it that the other proposed changes in this PR outside of those to pom.xml are related to the spotbugs analysis?
Also, @dk2k please open a JIRA ticket so that this contribution can be included in the release report.

@dk2k
Copy link
Contributor Author

dk2k commented Jan 17, 2022

Hi @lewismc ,
thanks for picking the PR up.
Indeed, all the changes outside POM are a reaction to found issues.
Created Jira ticket https://issues.apache.org/jira/browse/TIKA-3649
Later will post similar PRs for the rest of the modules.

THausherr
THausherr approved these changes Jan 18, 2022
View reviewed changes
Copy link
Contributor

@THausherr THausherr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me.

lewismc
lewismc requested changes Jan 18, 2022
View reviewed changes
Copy link
Member

@lewismc lewismc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dk2k please see minor comments. Thank you

tika-core/src/main/java/org/apache/tika/language/detect/LanguageNames.java Show resolved Hide resolved
tika-core/src/main/java/org/apache/tika/language/detect/LanguageNames.java Show resolved Hide resolved
tika-core/src/main/java/org/apache/tika/parser/RecursiveParserWrapper.java Show resolved Hide resolved
tika-core/src/main/java/org/apache/tika/utils/AnnotationUtils.java Outdated Show resolved Hide resolved
@dk2k dk2k requested a review from lewismc January 19, 2022 16:26
lewismc
lewismc approved these changes Jan 20, 2022
View reviewed changes
Copy link
Member

@lewismc lewismc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@lewismc lewismc changed the title Stat analysis core TIKA-3649 Stat analysis core Jan 20, 2022
@lewismc lewismc changed the title TIKA-3649 Stat analysis core TIKA-3649 Perform findbugs static analysis on the project and address the issues Jan 20, 2022
@lewismc lewismc merged commit 0f81174 into apache:main Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@THausherr THausherr THausherr approved these changes

@lewismc lewismc lewismc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@dk2k @lewismc @THausherr