TIKA-3815: set GMT timezone for unspecified timezones like drew noakes, #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix tests to work on different timezones
|
Should this be also applied to 1.x branch or we are just fixing security issues? |
|
I did a few more tests and I think this is fine, I'm going to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes TIKA-3815.
Actually Drew Noakes metadata-extractor library uses GMT timezone when timezone is not specified since version 2.8.1, not JVM default:
fix tests to work on different timezones
So I changed the code to reflect that and updated tests. Now
user.timezonedoesn't need to be fixed to UTC anymore to run tests, they should work on any timezone.I would like some other committer to test this to be sure tests work on a timezone different than mine (GMT-3)