TILES-583 changed the broken link #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -39,5 +39,5 @@ Integration with other web Frameworks | |||
|
|
|||
|
|
|||
| For a closer look at custom integrations the | |||
| {{{https://github.com/spring-projects/spring-framework/tree/master/spring-webmvc-tiles3/src/main/java/org/springframework/web/servlet/view/tiles3}spring code}}: | |||
| {{{https://github.com/spring-projects/spring-framework/tree/v3.2.0.RELEASE/spring-webmvc-tiles3/src/main/java/org/springframework/web/servlet/view/tiles3}spring code}}: | |||
There was a problem hiding this comment.
have you considered the alternative? that would be linking to
There was a problem hiding this comment.
That may be better, as it would be up to date, but may have problems if they reorganise the repo again. Also the wording about the spring versions would want to be changed to be 3.2 and later I think. If showing the latest is best I can do that.
There was a problem hiding this comment.
i'm happy to (and will) commit this as-is.
thanks for the contribution!
asfgit
pushed a commit
that referenced
this pull request
Mar 12, 2015
Just changed the link in the web framework integrations page to point to the version of spring-mvc that has the sample code in it's repository. Contribution from Clare Donnelly ref: #3 git-svn-id: https://svn.apache.org/repos/asf/tiles/framework/branches/TILES_3_0_X@1666175 13f79535-47bb-0310-9956-ffa450edef68
|
committed. Clare, could you close this pull request (given you're happy with it) please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just changed the link in the web framework integrations page to point to the version of spring-mvc that has the sample code in it's repository. https://issues.apache.org/jira/browse/TILES-583