Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TINKERPOP-2336 Added getMaxWaitForClose java driver setting. #1255

Merged
merged 1 commit into from Mar 5, 2020

Conversation

spmallette
Copy link
Contributor

@spmallette spmallette commented Feb 27, 2020

https://issues.apache.org/jira/browse/TINKERPOP-2336

This one has been basically done for a while now - just got delayed a bit because of 3.4.6. Made a few minor tweaks to docs after reviewing the last day or so, but other than that it's unchanged.

Deprecated the "close" message for sessions along with its driver setting. The driver should stay compatible with older server versions, but the server now closes sessions with the close of the connection and there no longer is a block while all messages return from the server after a Client.close().

All tests pass with docker/build.sh -t -n -i

VOTE +1

Deprecated the "close" message for sessions along with its driver setting. The driver should stay compatible with older server versions, but the server now closes sessions with the close of the connection and there no longer is a block while all messages return from the server after a Client.close().
@spmallette spmallette merged commit 118a15c into 3.3-dev Mar 5, 2020
@spmallette spmallette deleted the TINKERPOP-2336 branch March 5, 2020 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant