Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TINKERPOP-2445 Remove unnecessary initialization of serializers #1355

Merged
merged 2 commits into from
Nov 24, 2020

Conversation

divijvaidya
Copy link
Contributor

https://issues.apache.org/jira/browse/TINKERPOP-2445

Change

Remove deprecated methods.

Motivation

Initialization of GraphsonV1.0 is a major contributor (~28%) to initialize a client with a single connection.

@spmallette
Copy link
Contributor

I think that the value of the speed improvement here is worth the removal and the possible breaking change. The scope of the "break" itself seems fairly narrow and isolated - this will not affect a lot of users (if any). If I want to take a breaking change like this within patch versions I usually just email the dev list with a DISCUSS thread and explain the reasoning/scope for the breaking change (I sometimes even email the user list if i feel it is of effect to a large number of users who might want to have an objection but i don't think that's necessary for this change). I then end the dev list post with a statement of a "72 hour lazy consensus in effect" and then link the DISCUSS thread in the JIRA.

I don't think this change needs Upgrade Documentation, but a CHANGELOG entry would be good.

Note that these initializations have already been removed on master iirc.

Assuming all that is in place, then VOTE +1

@divijvaidya
Copy link
Contributor Author

@divijvaidya divijvaidya merged commit 4624355 into apache:3.4-dev Nov 24, 2020
@divijvaidya divijvaidya deleted the fastserializer branch November 24, 2020 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants