Improved pathing changes made for Windows Build Support

[L0Lmaker]

Pathing changes introduced to support the windows build of gremlin-javascript, gremlin-dotnet, and gremlint would make it so that building Tinkerpop or its modules from anywhere other than the Tinkerpop root would not work.

The changes in this PR would make it so that maven commands such as install, verify, compile and so on would work as expected from outside the root.

[lyndonbauto]

LGTM
VOTE+1

[FlorianHockmann]

I think this is definitely already a good improvement and most of the tests seem to pass this way, but I still run into problems with the Gherkin tests in gremlin-dotnet when executed from that directory:

mvn verify -pl :gremlin-dotnet,:gremlin-dotnet-tests -P gremlin-dotnet -DincludeNeo4j

leads to errors such as:

java.lang.IllegalStateException: data/tinkerpop-modern.xml does not exist

so it looks like more paths need to be changed to get full support for building and testing from other paths than the project's root.

But again, this is already a good improvement, so we can also merge this from my side without also fully supporting the Gherkin tests already.
Could you however please squash your commits? Would be better to have only one commit here instead of six.

[L0Lmaker]

I think this is definitely already a good improvement and most of the tests seem to pass this way, but I still run into problems with the Gherkin tests in gremlin-dotnet when executed from that directory:

mvn verify -pl :gremlin-dotnet,:gremlin-dotnet-tests -P gremlin-dotnet -DincludeNeo4j

leads to errors such as:

java.lang.IllegalStateException: data/tinkerpop-modern.xml does not exist

so it looks like more paths need to be changed to get full support for building and testing from other paths than the project's root.

I am able to reproduce the same error. I checked with an older version of the code without the windows build support changes in commit 38a3bd7 on 3.5 and the same error exists there as well.

Shall I document this in TINKERPOP-2760, which I made for pending windows tasks or create a new ticket for it?

[L0Lmaker]

Could you however please squash your commits? Would be better to have only one commit here instead of six.

Squashed in commit 6aa0d21

[FlorianHockmann]

I am able to reproduce the same error. I checked with an older version of the code without the windows build support changes in commit 38a3bd7 on 3.5 and the same error exists there as well.

Shall I document this in TINKERPOP-2760, which I made for pending windows tasks or create a new ticket for it?

If it's not specific to Windows, then I think that a separate ticket makes more sense.

VOTE +1

[L0Lmaker]

If it's not specific to Windows, then I think that a separate ticket makes more sense.

No, it is not specific to Windows, I will create a new ticket for it.

Update: Ticket created
TINKERPOP-2770