[TINKERPOP-2890] Avoid exceptions on local scope based steps where possible #2012
Conversation
Codecov Report
@@ Coverage Diff @@
## 3.5-dev #2012 +/- ##
=============================================
- Coverage 69.37% 64.16% -5.22%
=============================================
Files 866 25 -841
Lines 41183 3750 -37433
Branches 5423 0 -5423
=============================================
- Hits 28570 2406 -26164
+ Misses 10704 1166 -9538
+ Partials 1909 178 -1731 see 841 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Could you please add some feature tests for each of the steps that were changed so that this functionality is validated? Probably check to see if there are tests in general for this for all |
| @@ -54,7 +54,7 @@ protected S map(final Traverser.Admin<S> traverser) { | |||
| start instanceof Collection ? ((Collection) start).size() : | |||
| start instanceof Path ? ((Path) start).size() : | |||
| start instanceof Iterable ? IteratorUtils.count((Iterable) start) : | |||
| this.limit; | |||
| IteratorUtils.count(IteratorUtils.asIterator(start)); | |||
There was a problem hiding this comment.
is this meant as some sort of safety? RangeLocalStep.applyRange() seems to satisfy the issue, no? no exception thrown here:
gremlin> g.inject([1,2,3],[1],10).tail(local)
==>3
==>1
==>10
There was a problem hiding this comment.
also to handle arrays as input
gremlin> g.inject([1,2,3] as int[], [1]).tail(local,1)
==>[1, 2, 3]
==>1
| | josh | | ||
|
|
||
| Scenario: g_injectX1X_dedupXlocalX_unfold |
There was a problem hiding this comment.
this was the contrived example from the JIRA, but i think it comes with the downside that you had to add OptOut for them in computer tests. could you come up with tests that don't require that OptOut please?
|
VOTE+1 |
|
VOTE +1 |
1 similar comment
|
VOTE +1 |
Several local steps extended to work with input other than
Iterable.g.inject(1).dedup(local)is now valid query.Affected steps: count, dedup, max, mean, min, order, range, sample, sum, tail.