Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TINKERPOP-2863 Update hasId step mid-traversal processing #2019

Merged

Conversation

xiazcy
Copy link
Contributor

@xiazcy xiazcy commented Apr 12, 2023

https://issues.apache.org/jira/browse/TINKERPOP-2863

Aligned mid-traversal hasId() processing of lists with TinkerGraphStep filtering, to use P.within to check within lists of ids instead of using P.eq to compare entire list.

This preserves the effect where that one cannot query list typed ids (because we look within the list) that has been present historically with vertex/edge id filtering in g.V()/g.E().

It also fixes the behavior where arrays in the varargs are unrolled but not lists.

@codecov-commenter
Copy link

codecov-commenter commented Apr 12, 2023

Codecov Report

Merging #2019 (b4e233f) into 3.5-dev (4855073) will decrease coverage by 0.05%.
The diff coverage is 83.33%.

@@              Coverage Diff              @@
##             3.5-dev    #2019      +/-   ##
=============================================
- Coverage      69.37%   69.33%   -0.05%     
+ Complexity      8967     8961       -6     
=============================================
  Files            866      866              
  Lines          41219    41212       -7     
  Branches        5432     5431       -1     
=============================================
- Hits           28597    28575      -22     
- Misses         10708    10727      +19     
+ Partials        1914     1910       -4     
Impacted Files Coverage Δ
...in/process/traversal/dsl/graph/GraphTraversal.java 92.15% <83.33%> (+1.34%) ⬆️

... and 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vkagamlyk
Copy link
Contributor

LGTM, VOTE+1

…n to arrays, so P.within is applied to Collection
@xiazcy xiazcy force-pushed the yang/TINKERPOP-2863-fix-hasid-arraylist-args branch from fbc381f to 0c1bf93 Compare April 13, 2023 22:23
@kenhuuu
Copy link
Contributor

kenhuuu commented Apr 14, 2023

VOTE +1

@spmallette
Copy link
Contributor

This needs feature tests to enforce the behavior.

@xiazcy
Copy link
Contributor Author

xiazcy commented Apr 17, 2023

This needs feature tests to enforce the behavior.

Added in be12e6c

@xiazcy xiazcy merged commit ca96129 into apache:3.5-dev Apr 21, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants