Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce new marker interfaces to identify whether a step can perform write or delete or both on graph data and static map to capture steps associated with an operator #2023

Closed
wants to merge 2 commits into from

Conversation

phanindhra876
Copy link
Contributor

Currently all steps that can change graph data implements Mutating interface. However, there is no straight forward way to know whether the step can perform write or delete or both on the graph data. This PR introduces two new marker interfaces Writing and Deleting defining whether step can perform write or delete or both.

In addition to this, this PR creates a static map of Traversal steps that shall be added for a given operator. Both can be combined to assess whether a given query can perform read or write or delete or any combination of these before query execution.

@codecov-commenter
Copy link

Codecov Report

Merging #2023 (dddf95c) into master (8267ec1) will decrease coverage by 4.98%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #2023      +/-   ##
============================================
- Coverage     69.40%   64.43%   -4.98%     
============================================
  Files           878       25     -853     
  Lines         42093     3821   -38272     
  Branches       5645        0    -5645     
============================================
- Hits          29214     2462   -26752     
+ Misses        10883     1187    -9696     
+ Partials       1996      172    -1824     

see 861 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@phanindhra876 phanindhra876 deleted the step_map_3.6-dev branch April 17, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants