Fixed MergeV/MergeE steps to work when onCreate is immutable map #2028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 3.6-dev #2028 +/- ##
=============================================
+ Coverage 64.43% 69.47% +5.03%
- Complexity 0 9340 +9340
=============================================
Files 25 878 +853
Lines 3793 42234 +38441
Branches 0 5645 +5645
=============================================
+ Hits 2444 29341 +26897
- Misses 1181 10902 +9721
- Partials 168 1991 +1823
... and 852 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
kenhuuu
reviewed
Apr 21, 2023
| * Introduced `Writing` and `Deleting` marker interfaces to identify whether a step can perform write or delete or both on Graph. | ||
| * Added static map capturing possible Traversal steps that shall be added to traversal for a given operator | ||
|
|
||
|
|
There was a problem hiding this comment.
small nit: added extra new line
|
VOTE +1 |
|
VOTE+1 |
|
VOTE +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation of MergeV/MergeE doesn't work when
Merge.onCreateis immutable map.https://issues.apache.org/jira/browse/TINKERPOP-2926