Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notice for renaming none() to discard() #2408

Merged
merged 3 commits into from
Dec 20, 2023

Conversation

ryn5
Copy link
Contributor

@ryn5 ryn5 commented Dec 18, 2023

Provides notice in release notes that none() will be renamed to discard() in #2377.

@Cole-Greer
Copy link
Contributor

LGTM VOTE +1

Copy link
Contributor

@xiazcy xiazcy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VOTE +1.
Just minor nit to make it clearer in the title.

docs/src/upgrade/release-3.7.x.asciidoc Outdated Show resolved Hide resolved
docs/src/upgrade/release-3.7.x.asciidoc Outdated Show resolved Hide resolved
ryn5 and others added 2 commits December 20, 2023 11:35
Co-authored-by: Yang Xia <55853655+xiazcy@users.noreply.github.com>
Co-authored-by: Yang Xia <55853655+xiazcy@users.noreply.github.com>
@vkagamlyk
Copy link
Contributor

VOTE+1

@Cole-Greer Cole-Greer merged commit c28aa2e into apache:3.7-dev Dec 20, 2023
24 checks passed
ryn5 added a commit to Bit-Quill/tinkerpop that referenced this pull request Dec 20, 2023
Provides notice in release notes that none() will be renamed to discard() in TinkerPop 4.0
ryn5 added a commit to Bit-Quill/tinkerpop that referenced this pull request Dec 20, 2023
Provides notice in release notes that none() will be renamed to discard() in TinkerPop 4.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants