rework remote console #2611
Merged
rework remote console #2611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenhuuu
reviewed
May 23, 2024
| @@ -39,6 +39,12 @@ limitations under the License. | |||
| <artifactId>tinkergraph-gremlin</artifactId> | |||
| <version>${project.version}</version> | |||
| </dependency> | |||
| <dependency> | |||
| <groupId>com.fasterxml.jackson.core</groupId> | |||
| <artifactId>jackson-databind</artifactId> | |||
There was a problem hiding this comment.
Is this necessary? We purposely put jackson in gremlin-shaded to avoid doing things like this.
There was a problem hiding this comment.
it doesn't work without this
There was a problem hiding this comment.
aws sdk used for sigv4 require jackson-databind
cluster = Cluster.build("localhost").port(8182).auth(sigv4("us-west2")).create()
g = traversal().withRemote(DriverRemoteConnection.using(cluster, "g"))
leads to
java.lang.NoClassDefFoundError: com/fasterxml/jackson/databind/ObjectMapper
kenhuuu
reviewed
May 23, 2024
gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Settings.java
Outdated
Show resolved
Hide resolved
kenhuuu
reviewed
May 23, 2024
gremlin-console/src/main/groovy/org/apache/tinkerpop/gremlin/console/Console.groovy
Outdated
Show resolved
Hide resolved
kenhuuu
reviewed
May 23, 2024
gremlin-console/src/main/groovy/org/apache/tinkerpop/gremlin/console/Mediator.groovy
Outdated
Show resolved
Hide resolved
gremlin-console/src/main/java/org/apache/tinkerpop/gremlin/console/jsr223/ConnectionHelper.java
Outdated
Show resolved
Hide resolved
gremlin-console/src/test/groovy/org/apache/tinkerpop/gremlin/console/GremlinGroovyshTest.groovy
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.