Bytecode removal from Java GLV #2648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting in 4.0, gremlin-driver only supports GraphBinary.
Updated to match old behavior where the incoming size of the data is checked so that it doesn't exceed the maxContentLength setting.
xiazcy
reviewed
Jun 11, 2024
| @@ -79,7 +79,7 @@ public GremlinScriptEngineFactory getFactory() { | |||
| * Bytecode is evaluated by the {@link JavaTranslator}. | |||
| */ | |||
| @Override | |||
| public Traversal.Admin eval(final Bytecode bytecode, final Bindings bindings, final String traversalSource) throws ScriptException { | |||
| public Traversal.Admin eval(final GremlinLang bytecode, final Bindings bindings, final String traversalSource) throws ScriptException { | |||
There was a problem hiding this comment.
nit: rename variable as well to avoid confusion. I see this throughout all files, so prob need a search and update all references at some point.
Suggested change
| public Traversal.Admin eval(final GremlinLang bytecode, final Bindings bindings, final String traversalSource) throws ScriptException { | |
| public Traversal.Admin eval(final GremlinLang gremlinLang, final Bindings bindings, final String traversalSource) throws ScriptException { |
There was a problem hiding this comment.
I hope to remove this altogether in one of the next PRs, 'GremlinScriptEngineFactory' will handle only gremlin scripts.
| @@ -177,7 +175,7 @@ | |||
| import java.util.stream.Stream; | |||
|
|
|||
| /** | |||
| * Utility class for parsing {@link Bytecode}. | |||
| * Utility class for parsing {@link GremlinLang}. | |||
There was a problem hiding this comment.
nit: don't forget classname update
added 2 commits
June 11, 2024 15:39
|
VOTE +1 |
added 2 commits
June 13, 2024 11:08
|
VOTE +1 |
1 similar comment
|
VOTE +1 |
Cole-Greer
reviewed
Jun 13, 2024
...n-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/util/BytecodeHelper.java
Show resolved
Hide resolved
|
VOTE +1 |
kenhuuu
pushed a commit
that referenced
this pull request
Jul 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Java GLV will no longer send requests as Bytecode.
Feature tests
GraphBinaryRemoteFeatureTestswitched to run withgremlin-langdue to minor incompatibilities withgremlin-groovy.