Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding getters for internal fields inside sample step. #2649

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

upadhyay-prashant
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 76.77%. Comparing base (2d32517) to head (963c03b).
Report is 185 commits behind head on master.

Files Patch % Lines
...rocess/traversal/step/filter/SampleGlobalStep.java 0.00% 1 Missing ⚠️
...in/process/traversal/step/map/SampleLocalStep.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2649      +/-   ##
============================================
+ Coverage     76.16%   76.77%   +0.60%     
- Complexity    13170    13867     +697     
============================================
  Files          1085     1102      +17     
  Lines         65189    68127    +2938     
  Branches       7289     7398     +109     
============================================
+ Hits          49651    52304    +2653     
- Misses        12830    13098     +268     
- Partials       2708     2725      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@upadhyay-prashant upadhyay-prashant changed the base branch from master to 3.7-dev June 11, 2024 20:08
@Cole-Greer
Copy link
Contributor

Thanks for the submission Prashant!
VOTE +1
Looks good to me and as it's a relatively minor change, I will merge it as a CTR.

@Cole-Greer Cole-Greer merged commit 8623b2e into apache:3.7-dev Jun 11, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants