TINKERPOP-1679: Detached side-effects aren't attached when remoted #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es are respected. Exposed PropertyTests that were OPT_OUT in RemoteGraph, but didn't need to be. Added a Python test to verify the specific ticket test passes (though tested in ProcessTestSuite). The real problem is that Python does not have Serializers for Graph elements. It only has deserializers. I added serializers of the ReferenceXXX form. This way, elements can be passed in as parameters. Added read/write graphson tests in Python to verify serialization/deserialization behavior.
…s in the last push.
…minute to AddEdgeTest. Fixed.
|
|
All tests pass with VOTE +1 |
|
VOTE: +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/TINKERPOP-1679
This was occurring because Gremlin-Python did not have serializers for the Graph elements. I created serializers which are of the
ReferenceXXXform. I added serializer tests as well as add anAddEdgeTestand specific Gremlin-Python test for the traversal specified in the ticket. I also exposed twoProjectTestOPT_OUTsinRemoteGraph. I don't know why those wereOPT_OUTas OLAP will automatically fail accordingly beyond the star graph.VOTE +1.