TINKERPOP-1832: TraversalHelper.replaceStep sets previousStep to the wrong step #751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…teps' previousStep incorrectly. It needs to remove the replaced step before inserting the new step.
|
VOTE +1 |
|
This PR is targetted at master (3.3.x) - any reason to not also target tp32 (3.2.x) or is this just a problem on the 3.3.x line? |
|
I'd have to check but pretty sure its the same on 3.2.x |
|
It is the same in 3.2.x and was actually testing the fix in VOTE: +1 (after retargeting) |
|
Closing to retarget tp32 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/TINKERPOP-1832
TraversalHelper.replaceStepneeds to first remove the step before adding in the new step. Else it gets itspreviousSteppointer wrong.Added
TraversalHelperTest.shouldSetPreviousStepToEmptyStepwhich was the scenario that originally made me aware of the issue.Ran
mvn clean installand tested Sqlg's tests with the fix.