TINKERPOP-1943 Support GraphSON3 in Gremlin-JavaScript #858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spmallette
reviewed
Apr 25, 2018
| @@ -33,7 +33,7 @@ const responseStatusCode = { | |||
| noContent: 204, | |||
| partialContent: 206 | |||
| }; | |||
| const defaultMimeType = 'application/vnd.gremlin-v2.0+json'; | |||
| const defaultMimeType = 'application/vnd.gremlin-v3.0+json'; | |||
There was a problem hiding this comment.
Is there a way to configure for GraphSON 2.0? Also, I assume that the tests are running on GraphSON 3.0 now, but do they also run for GraphSON 2.0 still?
There was a problem hiding this comment.
The user can configure to use GraphSON2 by setting the mime type when creating the DriverRemoteConnection instance:
const connection = new DriverRemoteConnection({ mimeType: 'application/vnd.gremlin-v2.0+json' });I think in any case, is highly unlikely a user would like to use a previous version of the serialization format with the newer version.
It now defaults to GraphSON3 and all tests run using GraphSON3. I haven't changed the scripts to make a GraphSON2 and GraphSON3 run as one is a superset of the other.
|
VOTE +1 (pending a CHANGELOG entry) |
|
VOTE: +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for GraphSON3 to the JavaScript GLV.
https://issues.apache.org/jira/browse/TINKERPOP-1943
All gherkin scenarios are passing:
465 scenarios (27 skipped, 438 passed)VOTE +1