TINKERPOP-1913 Make status attributes available #933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test graphs are now named differently given the refactoring that went into improving integration configurations. Also fixed a bug in NO_CONTENT messages and added a test.
Didn't seem necessary to set them directly into a member variable on ResultQueue when they could be passed more safely by just including them with the completion state update
Adds StatusAttributes property on ResponseException. Removed explicit this from ResultSet<T> to align with existing style.
Merged
|
Thanks for taking this forward. When can we expect the rc2 nuget package? |
|
Assuming there are no objections on the dev list to doing a release candidate for 3.4.0 then it could be as early as next week, but that discussion needs to run to completion. Please follow along here: |
|
VOTE +1 |
1 similar comment
|
VOTE +1 |
|
This is a great step. Now that #922 - TINKERPOP-1959 has been closed, when would we expect to see ResultSets containing the necessary attributes in gremlin-javascript? That's super interesting for surfacing performance stats to the various clients :). |
|
I just created this: https://issues.apache.org/jira/browse/TINKERPOP-2064 in reference to gremlin-javascript |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/TINKERPOP-1913
Status attributes have always been returned from Gremlin Server but they haven't been easy to access unless you were working with the lower end of the protocol. They are now available in a fairly wide number of ways across most of the various drivers in a fairly consistent fashion. The current gap in this feature is related to gremlin-javascript probably needs #922 - TINKERPOP-1959 so that we even have a "ResultSet" of sorts to hold the status attributes and make them available.
Note that the travis error seems to be weirdness in travis:
don't think that's anything that's really failing.
All tests pass with
docker/build.sh -t -n -iVOTE +1