TINKERPOP-2061 Added with() option for traversal configuration #961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkuppitz
reviewed
Oct 11, 2018
| strategy.getOptions().forEach(builder::with); | ||
| builder.with(key, value); | ||
| return withStrategies(builder.create()); | ||
| } |
There was a problem hiding this comment.
Perhaps a little bit more elegant:
public default TraversalSource with(final String key, final Object value) {
final OptionsStrategy.Builder builder = OptionsStrategy.build();
getStrategies().getStrategy(OptionsStrategy.class)
.ifPresent(optionsStrategy -> optionsStrategy.getOptions().forEach(builder::with));
builder.with(key, value);
return withStrategies(builder.create());
}Basically just shorthands the direct use of OptionStrategy which is much more verbose and less nice to look at.
spmallette
force-pushed
the
TINKERPOP-2061
branch
from
49cb1dc
to
29eb3f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/TINKERPOP-2061
Basically just shorthands the direct use of
OptionStrategywhich is much more verbose and less nice to look at. See the upgrade doc changes in this PR for an example of usage.All tests pass with
docker/build.sh -t -n -iVOTE +1