TINKERPOP-2070: Introduce Connection and ResultSet abstractions #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extract Connection implementation out of the DriverRemoteConnection. The DriverRemoteConnection uses a Client instance, a Client instance may contain one or more Connection instances.
- Client and Connection submit() method returns a ResultSet instance - DriverRemoteConnection returns an instance of RemoteTraversal - Include gremlin script submission via gremlin-javascript in reference docs - ResultSet tests and other test fixes
|
VOTE +1 |
spmallette
reviewed
Oct 27, 2018
| .then(response => { | ||
| console.log(response.traversers.length); | ||
| console.log(response.traversers[0]); | ||
| client.submit('g.V().tail()') |
There was a problem hiding this comment.
we usually don't edit past upgrade notes - they are static and bound to that version, but i think i see what you're trying to do here, i.e. hide away traversers....i guess that's ok
There was a problem hiding this comment.
Yes, the idea is to hide a deprecated property :)
|
VOTE +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/TINKERPOP-2070
Extract
Connectionimplementation out of theDriverRemoteConnection.The
DriverRemoteConnectionnow uses aClientinstance, aClientinstance may contain one or moreConnectioninstances, similar to the Python and .NET glv.Introduce
ResultSetthat is aligned to other GLVs:ClientandConnectionsubmit()methods return aResultSetinstanceDriverRemoteConnectionsubmissions returns an instance ofRemoteTraversal.This is a large-ish refactor but it doesn't represent a breaking change for the user.
Additionally, I've identified an issue when we introduced script submission support in gremlin-javascript (my bad!): We exposed a property named
traversers(see previous code examples). I've maintained that property and marked it as deprecated, to be removed in 3.4, and updated all code examples to stop referencing to it.