Skip to content

Fix Clang 15/16 compatibility - #6

Merged
markt-asf merged 2 commits into
apache:mainfrom
thesamesam:clang-16-implicit-int
Sep 4, 2023
Merged

Fix Clang 15/16 compatibility#6
markt-asf merged 2 commits into
apache:mainfrom
thesamesam:clang-16-implicit-int

Conversation

@thesamesam

@thesamesam thesamesam commented Oct 17, 2022

Copy link
Copy Markdown
Contributor

No description provided.

@thesamesam thesamesam changed the title Fix -Wimplicit-int Fix Clang 15 compatibility Oct 17, 2022
Comment thread native/configure.ac
@thesamesam
thesamesam force-pushed the clang-16-implicit-int branch from c896afd to df89b1f Compare October 17, 2022 20:39

@ChristopherSchultz ChristopherSchultz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is stdlib.h being added along with this commit?

@thesamesam

thesamesam commented Oct 17, 2022

Copy link
Copy Markdown
Contributor Author

Why is stdlib.h being added along with this commit?

exit(). Note there's two commits:

  1. For -Wimplicit-int
  2. For -Wimplicit-function-declaration

EDIT: I've made the commit messages more detailed.

@thesamesam
thesamesam force-pushed the clang-16-implicit-int branch 2 times, most recently from 28779c2 to d8c148f Compare October 17, 2022 22:24
@thesamesam thesamesam changed the title Fix Clang 15 compatibility Fix Clang 15/16 compatibility Oct 17, 2022
Clang 16 will make -Wimplicit-int error by default.

For more information, see LWN.net [0] or LLVM's Discourse [1], gentoo-dev@ [2],
or the (new) c-std-porting mailing list [3].

[0] https://lwn.net/Articles/913505/
[1] https://discourse.llvm.org/t/configure-script-breakage-with-the-new-werror-implicit-function-declaration/65213
[2] https://archives.gentoo.org/gentoo-dev/message/dd9f2d3082b8b6f8dfbccb0639e6e240
[3] hosted at lists.linux.dev.

Signed-off-by: Sam James <sam@gentoo.org>
Clang 16 will make -Wimplicit-function-declaration error by default.

Follow-up to e719874. Needed for `exit()`.

For more information, see LWN.net [0] or LLVM's Discourse [1], gentoo-dev@ [2],
or the (new) c-std-porting mailing list [3].

[0] https://lwn.net/Articles/913505/
[1] https://discourse.llvm.org/t/configure-script-breakage-with-the-new-werror-implicit-function-declaration/65213
[2] https://archives.gentoo.org/gentoo-dev/message/dd9f2d3082b8b6f8dfbccb0639e6e240
[3] hosted at lists.linux.dev.

Signed-off-by: Sam James <sam@gentoo.org>
@thesamesam
thesamesam force-pushed the clang-16-implicit-int branch from d8c148f to a276afb Compare November 5, 2022 06:18
@markt-asf
markt-asf merged commit 21f5a92 into apache:main Sep 4, 2023
@thesamesam
thesamesam deleted the clang-16-implicit-int branch September 4, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants