Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Clang 15/16 compatibility #6

Merged
merged 2 commits into from
Sep 4, 2023

Conversation

thesamesam
Copy link
Contributor

@thesamesam thesamesam commented Oct 17, 2022

No description provided.

@thesamesam thesamesam changed the title Fix -Wimplicit-int Fix Clang 15 compatibility Oct 17, 2022
Copy link

@ChristopherSchultz ChristopherSchultz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is stdlib.h being added along with this commit?

@thesamesam
Copy link
Contributor Author

thesamesam commented Oct 17, 2022

Why is stdlib.h being added along with this commit?

exit(). Note there's two commits:

  1. For -Wimplicit-int
  2. For -Wimplicit-function-declaration

EDIT: I've made the commit messages more detailed.

@thesamesam thesamesam force-pushed the clang-16-implicit-int branch 2 times, most recently from 28779c2 to d8c148f Compare October 17, 2022 22:24
@thesamesam thesamesam changed the title Fix Clang 15 compatibility Fix Clang 15/16 compatibility Oct 17, 2022
Clang 16 will make -Wimplicit-int error by default.

For more information, see LWN.net [0] or LLVM's Discourse [1], gentoo-dev@ [2],
or the (new) c-std-porting mailing list [3].

[0] https://lwn.net/Articles/913505/
[1] https://discourse.llvm.org/t/configure-script-breakage-with-the-new-werror-implicit-function-declaration/65213
[2] https://archives.gentoo.org/gentoo-dev/message/dd9f2d3082b8b6f8dfbccb0639e6e240
[3] hosted at lists.linux.dev.

Signed-off-by: Sam James <sam@gentoo.org>
Clang 16 will make -Wimplicit-function-declaration error by default.

Follow-up to e719874. Needed for `exit()`.

For more information, see LWN.net [0] or LLVM's Discourse [1], gentoo-dev@ [2],
or the (new) c-std-porting mailing list [3].

[0] https://lwn.net/Articles/913505/
[1] https://discourse.llvm.org/t/configure-script-breakage-with-the-new-werror-implicit-function-declaration/65213
[2] https://archives.gentoo.org/gentoo-dev/message/dd9f2d3082b8b6f8dfbccb0639e6e240
[3] hosted at lists.linux.dev.

Signed-off-by: Sam James <sam@gentoo.org>
@markt-asf markt-asf merged commit 21f5a92 into apache:main Sep 4, 2023
@thesamesam thesamesam deleted the clang-16-implicit-int branch September 4, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants