Avoid useless add operation

apache · Feb 13, 2024 · 3a9dbd1 · 3a9dbd1
1 parent 4320e1a
commit 3a9dbd1
Showing 1 changed file with 12 additions and 4 deletions.
diff --git a/java/org/apache/coyote/http11/upgrade/UpgradeGroupInfo.java b/java/org/apache/coyote/http11/upgrade/UpgradeGroupInfo.java
@@ -61,7 +61,9 @@ public long getBytesReceived() {
     }
     public void setBytesReceived(long bytesReceived) {
         deadBytesReceived.reset();
-        deadBytesReceived.add(bytesReceived);
+        if (bytesReceived != 0) {
+            deadBytesReceived.add(bytesReceived);
+        }
         for (UpgradeInfo ui : upgradeInfos) {
             ui.setBytesReceived(bytesReceived);
         }
@@ -77,7 +79,9 @@ public long getBytesSent() {
     }
     public void setBytesSent(long bytesSent) {
         deadBytesSent.reset();
-        deadBytesSent.add(bytesSent);
+        if (bytesSent != 0) {
+            deadBytesSent.add(bytesSent);
+        }
         for (UpgradeInfo ui : upgradeInfos) {
             ui.setBytesSent(bytesSent);
         }
@@ -93,7 +97,9 @@ public long getMsgsReceived() {
     }
     public void setMsgsReceived(long msgsReceived) {
         deadMsgsReceived.reset();
-        deadMsgsReceived.add(msgsReceived);
+        if (msgsReceived != 0) {
+            deadMsgsReceived.add(msgsReceived);
+        }
         for (UpgradeInfo ui : upgradeInfos) {
             ui.setMsgsReceived(msgsReceived);
         }
@@ -109,7 +115,9 @@ public long getMsgsSent() {
     }
     public void setMsgsSent(long msgsSent) {
         deadMsgsSent.reset();
-        deadMsgsSent.add(msgsSent);
+        if (msgsSent != 0) {
+            deadMsgsSent.add(msgsSent);
+        }
         for (UpgradeInfo ui : upgradeInfos) {
             ui.setMsgsSent(msgsSent);
         }