Fix BZ 66627 - restore documented behaviour of MessageBytes.getType()

apache · Jun 8, 2023 · 897931b · 897931b
1 parent 414be86
commit 897931b
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/java/org/apache/tomcat/util/buf/MessageBytes.java b/java/org/apache/tomcat/util/buf/MessageBytes.java
@@ -169,11 +169,9 @@ public String toString() {
                 // No conversion required
                 break;
             case T_BYTES:
-                type = T_STR;
                 strValue = byteC.toString();
                 break;
             case T_CHARS:
-                type = T_STR;
                 strValue = charC.toString();
                 break;
         }
@@ -272,7 +270,6 @@ public void toBytes() {
         }
 
         byteC.setBytes(bb.array(), bb.arrayOffset(), bb.limit());
-        type = T_BYTES;
     }
 
 
@@ -294,7 +291,6 @@ public void toChars() {
                 toString();
                 //$FALL-THROUGH$
             case T_STR: {
-                type = T_CHARS;
                 char cc[] = strValue.toCharArray();
                 charC.setChars(cc, 0, cc.length);
             }

diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
@@ -114,6 +114,16 @@
       </fix>
     </changelog>
   </subsection>
+  <subsection name="Coyote">
+    <changelog>
+      <fix>
+        <bug>66627</bug>: Restore the documented behaviour of
+        <code>MessageBytes.getType()</code> that it returns the type of the
+        original content rather than reflecting the most recent conversion.
+        (markt)
+      </fix>
+    </changelog>
+  </subsection>
   <subsection name="WebSocket">
     <changelog>
       <fix>