Log compression #223
Closed
Log compression #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Logs Compression
This reverts commit eb21c5f.
Log Compression new Branch
Fix the try and catch
Remove unnessary files
remove unnessary file
…into LogCompression
Add CompressFileUtils to juli package
markt-asf
requested changes
Dec 4, 2019
| /** | ||
| * Determines whether the log file should be compressed | ||
| */ | ||
| private Boolean compress; |
There was a problem hiding this comment.
This needs to be documented in the class level Javadoc
| @@ -393,6 +430,9 @@ private void configure() { | |||
| if (suffix == null) { | |||
| suffix = getProperty(className + ".suffix", ".log"); | |||
| } | |||
| if (compress == null) { | |||
| compress = Boolean.valueOf(getProperty(className + ".compress", "true")); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
It looks like some tabs have crept in here. Tomcat uses 4 spaces for idents. I recommend enabling Checkstyle for you build as it will catch this sort of thing,
| @@ -0,0 +1,50 @@ | |||
| package org.apache.tomcat.util.file; | |||
There was a problem hiding this comment.
Needs an ALv2 header. Again Checkstyle will catch this.
| @@ -37,6 +37,7 @@ | |||
| import org.apache.juli.logging.LogFactory; | |||
| import org.apache.tomcat.util.ExceptionUtils; | |||
| import org.apache.tomcat.util.buf.B2CConverter; | |||
| import org.apache.tomcat.util.file.CompressFileUtils; | |||
|
|
|||
There was a problem hiding this comment.
Why not use the JULI version since the dependency is already there rather than duplicating the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modification has been done based on the below bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62611
Below are the modifications that has been done during the task:
1- org.apache.juli.FileHandler.compress();
2- org.apache.juli.FileHandler.deleteRotatedFile();
3- org.apache.catalina.valves compress();
4- org.apache.catalina.valves.deleteRotatedFile();
5- External configurations, where you can enable or disable the compression function based on new configurations keys to located in logging.properties
1catalina.org.apache.juli.AsyncFileHandler.compress = true
2localhost.org.apache.juli.AsyncFileHandler.compress = true
3manager.org.apache.juli.AsyncFileHandler.compress = true
4host-manager.org.apache.juli.AsyncFileHandler.compress = true