EL FunctionMapperImpl: skip Method lookup if not required#476
Closed
tandraschko wants to merge 1 commit intoapache:mainfrom
Closed
EL FunctionMapperImpl: skip Method lookup if not required#476tandraschko wants to merge 1 commit intoapache:mainfrom
tandraschko wants to merge 1 commit intoapache:mainfrom
Conversation
it fixes a ClassNotFoundException when using the wrong CL and skips the lookup for performance reasons in a correct enviroment
Member
Author
|
i would also be happy if you could backport it to 9.0.x |
Contributor
|
I do think you should try and find the root cause of the issue you are observing as it might be causing other issues. I'm not convinced the proposed change is the right one. There should be no need to call Looking at the history, it appears two separate fixes were applied for the same issue:
I'm going to refactor this and implement a different fix. |
Member
Author
|
@markt-asf thanks, even better! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we currently have a weird case, where it seems that our session-manager seems to use the wrong CL (memcached-session-manager), and therefore a ClassNotFoundException is logged.
Nevertheless, it only happens on the second request, where the method infos are already loaded.
So this PR improves the performance a bit as the lookup isnt done anymore for cases, where the infos are already loaded and it fixes our special case.