Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EL FunctionMapperImpl: skip Method lookup if not required #476

wants to merge 1 commit into from


Copy link

we currently have a weird case, where it seems that our session-manager seems to use the wrong CL (memcached-session-manager), and therefore a ClassNotFoundException is logged.
Nevertheless, it only happens on the second request, where the method infos are already loaded.

So this PR improves the performance a bit as the lookup isnt done anymore for cases, where the infos are already loaded and it fixes our special case.

it fixes a ClassNotFoundException when using the wrong CL and skips the lookup for performance reasons in a correct enviroment
Copy link
Member Author

i would also be happy if you could backport it to 9.0.x

Copy link

I do think you should try and find the root cause of the issue you are observing as it might be causing other issues.

I'm not convinced the proposed change is the right one. There should be no need to call getMethod() at all. If one of owner, name or types is null and m is null, calling getMethod() is just going to trigger an error. And m should not be null in that case anyway.

Looking at the history, it appears two separate fixes were applied for the same issue:

I'm going to refactor this and implement a different fix.

@markt-asf markt-asf closed this Feb 19, 2022
Copy link
Member Author

@markt-asf thanks, even better!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
2 participants