Improved logging of unknown http2 settings #487
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… id and value are available. Otherwise only INTEGER.MAX_VALUE will be written as id into the logfile.
… id and value are available. Otherwise only INTEGER.MAX_VALUE will be written as id into the logfile.
… id and value are available. Otherwise only INTEGER.MAX_VALUE will be written as id into the logfile.
|
Closing since the patch is wrong and I'm already about to commit it. |
|
Oh, actually, this has the key -> id change, but it should still do Integer.toString(id). |
rmaucher
added a commit
that referenced
this pull request
Mar 23, 2022
Pull request by Thomas Hoffmann.
|
Thank you for the quick response and help! |
rmaucher
added a commit
that referenced
this pull request
Mar 23, 2022
Pull request by Thomas Hoffmann.
rmaucher
added a commit
that referenced
this pull request
Mar 23, 2022
Pull request by Thomas Hoffmann.
rmaucher
added a commit
that referenced
this pull request
Mar 23, 2022
Pull request by Thomas Hoffmann.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logging of unknown http2 settings should contain the key and the value of the setting.
The key is currently converted into a setting object. Unknown keys are mapped to Integer.MAX_VALUE
Thus the log currently contains the MAX_VALUE as key and the value of the settings. The original key got lost during the conversion to the setting object.
Therefore the logging was moved to methods, which have access to the original key and the value.