transferTo can transfer only part of the file, so need to loop#613
Closed
jackshirazi wants to merge 1 commit intoapache:mainfrom
Closed
transferTo can transfer only part of the file, so need to loop#613jackshirazi wants to merge 1 commit intoapache:mainfrom
jackshirazi wants to merge 1 commit intoapache:mainfrom
Conversation
Contributor
|
LGTM |
Contributor
|
@rmaucher applied this PR earlier today. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We (Elastic APM) have a customer (using tomcat 9.0.72) that is hitting this bug. The file copy is getting interrupted (likely from CPU time slicing signals, which is happening because of additional profiling executing in the background) and so only partly completes. As the current implementation doesn't loop, this results in a corrupt war/zip file that can't be loaded. To complete the file copy, transferTo needs to loop