Remove org.apache.catalina.ssi from tomcat-embed-core.jar.tmp.bnd #684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This package no longer exits in 'tomcat-embed-core.jar'. It is in the 'module-info.class' of the current '10.1.18' and earlier 10.x releases. Running 'jlink' or 'jpackage' with a Module Path that contains 'tomcat-embed-core-10.1.18.jar' gives the following error: > jlink failed with: Error: Packages that are exported or open in org.apache.tomcat.embed.core are not present: [org.apache.catalina.ssi] Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
iherasymenko
added a commit
to iherasymenko/modular-spring-boot
that referenced
this pull request
Jan 14, 2024
markt-asf
added a commit
that referenced
this pull request
Jan 15, 2024
Remove reference to org.apache.catalina.ssi package that is no longer included in the JAR. Based on pull request #684 by Jendrik Johannes
markt-asf
added a commit
that referenced
this pull request
Jan 15, 2024
Remove reference to org.apache.catalina.ssi package that is no longer included in the JAR. Based on pull request #684 by Jendrik Johannes
markt-asf
added a commit
that referenced
this pull request
Jan 15, 2024
Remove reference to org.apache.catalina.ssi package that is no longer included in the JAR. Based on pull request #684 by Jendrik Johannes
Contributor
|
Fixed manually in main for 11.0.x (with change log entry) and then back-ported (cherry-picked) to 10.1.x and 9.0.x. |
Author
|
Thanks @markt-asf! |
iherasymenko
added a commit
to iherasymenko/modular-spring-boot
that referenced
this pull request
Jan 22, 2024
iherasymenko
added a commit
to iherasymenko/modular-spring-boot
that referenced
this pull request
Jan 22, 2024
iherasymenko
added a commit
to iherasymenko/modular-spring-boot
that referenced
this pull request
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This package no longer exits in
tomcat-embed-core.jar. It is in themodule-info.classof the current10.1.18and earlier10.xreleases.Running
jlinkorjpackagewith a Module Path that containstomcat-embed-core-10.1.18.jargives the following error: