Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid performance issues that may arise when the array is large. #702

Closed

Conversation

CloudWise-Lukemiao
Copy link

Code optimization 1. Avoid performance issues that may arise when the array is large. 2. Use the Arrays.copyOf method to adjust the size of the filter array

… array is large. 2. Use the Arrays.copyOf method to adjust the size of the filter array
@rmaucher
Copy link
Contributor

I think FilterDef getAsyncSupported can be optimized. But I'm not super convinced by the rest. Where is the inflection point ?

@rmaucher
Copy link
Contributor

I added some optimizations, still based on the array. If you investigate something, then fully using a LinkedHashSet would likely be better than HashSet + array. Please provide actual micro benchmarks to determine when/if it becomes better than the current code.

@rmaucher rmaucher closed this Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants