Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify usage of custom ssl configuration #706

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
82 changes: 82 additions & 0 deletions java/org/apache/tomcat/util/net/SSLContextWrapper.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,82 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.tomcat.util.net;

import javax.net.ssl.KeyManager;
import javax.net.ssl.SSLEngine;
import javax.net.ssl.SSLParameters;
import javax.net.ssl.SSLServerSocketFactory;
import javax.net.ssl.SSLSessionContext;
import javax.net.ssl.TrustManager;
import javax.net.ssl.X509KeyManager;
import javax.net.ssl.X509TrustManager;
import java.security.KeyManagementException;
import java.security.SecureRandom;
import java.security.cert.X509Certificate;

class SSLContextWrapper implements SSLContext {

private final javax.net.ssl.SSLContext sslContext;
private final X509KeyManager keyManager;
private final X509TrustManager trustManager;

public SSLContextWrapper(javax.net.ssl.SSLContext sslContext, X509KeyManager keyManager, X509TrustManager trustManager) {
this.sslContext = sslContext;
this.keyManager = keyManager;
this.trustManager = trustManager;
}

@Override
public void init(KeyManager[] kms, TrustManager[] tms, SecureRandom sr) throws KeyManagementException {
// not needed to initialize as it is already initialized
}

@Override
public void destroy() {

}

@Override
public SSLSessionContext getServerSessionContext() {
return sslContext.getServerSessionContext();
}

@Override
public SSLEngine createSSLEngine() {
return sslContext.createSSLEngine();
}

@Override
public SSLServerSocketFactory getServerSocketFactory() {
return sslContext.getServerSocketFactory();
}

@Override
public SSLParameters getSupportedSSLParameters() {
return sslContext.getSupportedSSLParameters();
}

@Override
public X509Certificate[] getCertificateChain(String alias) {
return keyManager.getCertificateChain(alias);
}

@Override
public X509Certificate[] getAcceptedIssuers() {
return trustManager.getAcceptedIssuers();
}
}
6 changes: 6 additions & 0 deletions java/org/apache/tomcat/util/net/SSLUtil.java
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@
import javax.net.ssl.KeyManager;
import javax.net.ssl.SSLSessionContext;
import javax.net.ssl.TrustManager;
import javax.net.ssl.X509KeyManager;
import javax.net.ssl.X509TrustManager;

/**
* Provides a common interface for {@link SSLImplementation}s to create the
Expand All @@ -31,6 +33,10 @@ public interface SSLUtil {

SSLContext createSSLContext(List<String> negotiableProtocols) throws Exception;

static SSLContext createSSLContext(javax.net.ssl.SSLContext sslContext, X509KeyManager keyManager, X509TrustManager trustManager) {
return new SSLContextWrapper(sslContext, keyManager, trustManager);
}

KeyManager[] getKeyManagers() throws Exception;

TrustManager[] getTrustManagers() throws Exception;
Expand Down