Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TOMEE-2097 - Improve community "Contribute to This Website" description #3

Merged
merged 2 commits into from Jul 17, 2017
Merged

TOMEE-2097 - Improve community "Contribute to This Website" description #3

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2431f5
improvement on community section - how to contribute to the website
ivanjunckes Jul 13, 2017
b527505
fixes based on romain's suggestion and adding video
ivanjunckes Jul 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 7 additions & 6 deletions src/main/jbake/content/community/index.adoc
View file
Open in desktop
Expand Up @@ -21,14 +21,15 @@ For more information about available support for TomEE please have a look on lin

=== Contribute to This Website

This website is a simple JBake project you can find at https://git-wip-us.apache.org/repos/asf/tomee-site-generator.git.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep asf repo as the main repository and add github as a subpart or alternative way to work but since it is a proxy we should make explicit that it is synch-ed and therefore not the main source of truth somehow IMHO.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the user needs to know what is behind the scenes regarding infrastructure if he will never do a PR to asf repository? Contributors will only work with github. That will make users confused in my opinion as they will have 2 different sources.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because is an option, nice one, but not the official one for asf projects.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

This website is a simple link:http://jbake.org/[JBake] project you can find at https://github.com/apache/tomee-site-generator.git.

For more information please have a look to
https://git-wip-us.apache.org/repos/asf?p=tomee-site-generator.git;a=blob;f=README.adoc;h=0fefd33b398fca05854ce46f3c5ebcb4a5ef107a;hb=refs/heads/master
and http://jbake.org/.
To submit a change do the following:

To submit a change create a ticket on http://issues.apache.org/jira/browse/TOMEE and attach a diff
with the content. Then a committer will review it and redeploy the website using Apache CMS.
- Create a ticket on http://issues.apache.org/jira/browse/TOMEE

- Open a PR with the ticket number e.g `TOMEE-1000 - Ticket Description`

A committer will review it and redeploy the website using Apache CMS.

Building the website is mainly about running `mvn compile`, note you can use `JBake` main to develop.
Publishing the website is about running `mvn pre-site` - needs to be a TomEE committer.