Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REAMDE Enhancements to setup TCK on developers machine #15

Merged
merged 1 commit into from
Jan 14, 2021

Conversation

rzo1
Copy link
Contributor

@rzo1 rzo1 commented Jan 14, 2021

What does this PR do?

I recently went through the setup section and tried to setup the TCK [1].

Thus, I updated the README to incorporate the things, which I encountered while doing so. I hope, that this will help others in setting up the TCK on their machines.

References

[1] https://lists.apache.org/thread.html/r9dd9733d56ba7679ab7aa35a61414e62d66434be3c81a51954ee922f%40%3Cdev.tomee.apache.org%3E

…ntributors can follow in order to setup tck on their machines
Copy link
Contributor

@jeanouii jeanouii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go ahead and merge it. You should have permissions (I hope).

@rzo1
Copy link
Contributor Author

rzo1 commented Jan 14, 2021

Go ahead and merge it. You should have permissions (I hope).

I think, that the write permissions are not given to my account yet - at least GitHub states "Only those with write access to this repository can merge pull requests." on all TomEE related repositories.

@jeanouii jeanouii merged commit 66e1382 into apache:master Jan 14, 2021
@rzo1 rzo1 deleted the readme-adjusted-master branch January 14, 2021 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants