TOMEE-4261 - JakartaEE 10 APIs + OWB4 #1066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates Tomcat to 10.1.x to be compatible with EE-10 APIs
…InjectionTargetFactory(AnnotatedType)} instead.
… due to different repos used for resolution in a full build
# Conflicts: # pom.xml
|
There is only one failing test left, which is related to OWB-4 and the handling of dotted EL expressions, cf. https://ci-builds.apache.org/job/Tomee/job/pull-request-manual/55/ |
…needed in OWB 4.0.0 to pass a test in the CDI TCK. Until OWB adds a workaround, we ignore the test on our side to avoid being blocked.
|
Build is green (ignoring the OWB related test): https://ci-builds.apache.org/job/Tomee/job/pull-request-manual/58/ |
struberg
approved these changes
Oct 23, 2023
Tomcat 10.1.15
# Conflicts: # pom.xml
# Conflicts: # examples/pom.xml
|
finally :) thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to EE-10 and OWB-4. It contains several dependency upgrades (related to EE10) as well as an upgrade to the EE-10 apis.
The latest full builds can be found here:
There is also a list discussion / asking-for-help thread on https://lists.apache.org/thread/fj3c7q3d6cq8tt1lc6z4tx2tddh8mr33
Notes
Couldn't cherry-pick some of the changes from the https://github.com/apache/tomee/tree/UpdateJakartaEEApi10 branch, which originate from @tandraschko (faces 4) and @jgallimore (concurrency)
The version was intentionally switched to
10.0.0-M1-SNAPSHOTto avoid getting "non-upgraded" dependencies for parts of the build from the remote repository. We can revert that commit, if needed.Add a profile
tck-cdito allow to disable it (for now) until we get it resolvedTODOs
org.superbiz.moviefun.MoviesHtmlUnitTest.testShouldMakeSureWebappIsWorking. This most likely fails due to a change in OWB 4 to pass the TCK. Currently, it is set to@Ignore: https://issues.apache.org/jira/browse/TOMEE-4258