TOMEE-4358 - Load SpringWebUtils in the context class loader in TomEE w… #1165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen the cxf-rs service is initialized
|
may i know how to contribute something to this project.. any project setup
guide etc.
…On Thu, May 23, 2024 at 3:25 PM Jonathan Gallimore ***@***.***> wrote:
…hen the cxf-rs service is initialized
------------------------------
You can view, comment on, or merge this pull request online at:
#1165
Commit Summary
- ff60d0d
<ff60d0d>
TOMEE-4332 Load SpringWebUtils in the context class loader in TomEE when
the cxf-rs service is initialized
File Changes
(9 files <https://github.com/apache/tomee/pull/1165/files>)
- *M*
arquillian/arquillian-tomee-tests/arquillian-tomee-jaxrs-tests/pom.xml
<https://github.com/apache/tomee/pull/1165/files#diff-84a03152e5e61c4c8eb0fd789255924913a5282b110b39dd54fffc374dd7a2f4>
(22)
- *A*
arquillian/arquillian-tomee-tests/arquillian-tomee-jaxrs-tests/src/test/java/org/apache/openejb/arquillian/tests/jaxrs/spring/AlternativeGreeter.java
<https://github.com/apache/tomee/pull/1165/files#diff-42b4bf19f1fd00c42fd9c614651849f16953751549621f02091afe5b7928cecb>
(22)
- *A*
arquillian/arquillian-tomee-tests/arquillian-tomee-jaxrs-tests/src/test/java/org/apache/openejb/arquillian/tests/jaxrs/spring/DemoApplication.java
<https://github.com/apache/tomee/pull/1165/files#diff-8445dba18580221bb63a940955a737356a510f48c35479bbcd0441bff673a72f>
(13)
- *A*
arquillian/arquillian-tomee-tests/arquillian-tomee-jaxrs-tests/src/test/java/org/apache/openejb/arquillian/tests/jaxrs/spring/GreetingController.java
<https://github.com/apache/tomee/pull/1165/files#diff-b6dae7952f5efabf54144fdd858fc68b278943f9f47a0aa5a0a2f958678bb7be>
(19)
- *A*
arquillian/arquillian-tomee-tests/arquillian-tomee-jaxrs-tests/src/test/java/org/apache/openejb/arquillian/tests/jaxrs/spring/ServletInitializer.java
<https://github.com/apache/tomee/pull/1165/files#diff-dc56cf14f0a93124da840cd246e8b4134ed2a8824ee6e1438695f1a92e121953>
(13)
- *A*
arquillian/arquillian-tomee-tests/arquillian-tomee-jaxrs-tests/src/test/java/org/apache/openejb/arquillian/tests/jaxrs/spring/SpringWebappTest.java
<https://github.com/apache/tomee/pull/1165/files#diff-c2daf3f2afe8f5d3568572e30c3a9c1c40f617c091c9296dead7b4325e00596c>
(158)
- *A*
arquillian/arquillian-tomee-tests/arquillian-tomee-jaxrs-tests/src/test/resources/spring-webmvc-pom.xml
<https://github.com/apache/tomee/pull/1165/files#diff-cca184508061abf53c1b71496a9102638983dd5db48f48e3647f9b008ac78f45>
(44)
- *M* arquillian/arquillian-tomee-tests/pom.xml
<https://github.com/apache/tomee/pull/1165/files#diff-a2f5f4c3f55990b49f7027a8ec8ebc454867bbb1f330f56f1708d61aa1bc114a>
(1)
- *M*
server/openejb-cxf-rs/src/main/java/org/apache/openejb/server/cxf/rs/CxfRSService.java
<https://github.com/apache/tomee/pull/1165/files#diff-03a49e7161ba61df5ee2131dcb82aef56a3dbebd671928e25dfd3fcff9180c0c>
(6)
Patch Links:
- https://github.com/apache/tomee/pull/1165.patch
- https://github.com/apache/tomee/pull/1165.diff
—
Reply to this email directly, view it on GitHub
<#1165>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABL6BELFJT42EDWFXUBUG4LZDW4INAVCNFSM6AAAAABIFJPXOSVHI2DSMVQWIX3LMV43ASLTON2WKOZSGMYTENBXGQ3DGOI>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
Further detail on the CXF list is here: https://lists.apache.org/thread/coxrst45zm8gqmf1hhx5g7bqzbsldkhh |
|
@venkat9 Your best bet is to join the users mailing list, and ask your question there. Best suggestion I can give concisely is to use TomEE, and if you identify bugs, discuss them on the mailing list with a view to fixing. Similarly, if you can see a feature you'd enjoy implementing, discuss that on the mailing list. |
rzo1
requested changes
May 23, 2024
| @@ -0,0 +1,22 @@ | |||
| package org.apache.openejb.arquillian.tests.jaxrs.spring; | |||
| @@ -0,0 +1,19 @@ | |||
| package org.apache.openejb.arquillian.tests.jaxrs.spring; | |||
| @@ -0,0 +1,13 @@ | |||
| package org.apache.openejb.arquillian.tests.jaxrs.spring; | |||
| @@ -0,0 +1,13 @@ | |||
| package org.apache.openejb.arquillian.tests.jaxrs.spring; | |||
| @@ -0,0 +1,44 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <parent> | ||
| <groupId>org.springframework.boot</groupId> | ||
| <artifactId>spring-boot-starter-parent</artifactId> | ||
| <version>3.1.11</version> |
There was a problem hiding this comment.
Spring Boot 3 has a Java 17 baseline, so this will likely fail the Java 11 based build. I think, that we would need to build an exclusion for that test if we run with a runtime below 17.
rzo1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…hen the cxf-rs service is initialized