Use Locale.ENGLISH to do proper toLower/UpperCase #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 17 commits
September 27, 2016 12:15
jgallimore
added a commit
to jgallimore/tomee
that referenced
this pull request
Jun 25, 2018
Release TomEE EAP 1.7.6-TT.6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In several places TomEE does not use proper toLower()/toUpper(). The issue is that if the server relies on the default locale and if the process was started with some non English compatible locale such as Turkish, toUpper/Lower will yield an incorrect result. For instance "URI".toLowerCase() will result in "urı" instead of "uri". The same applies to toUpperCase -> "uri".toUpperCase() will become "URİ" and checks like "string.toUpperCase().equals(someConstant)" will fail.
In some places I left the usage of the default locale, because IMO using a fixed locale is equally incorrect. Those places are:
MultivaluedMap:144
ProviderManager:78
DeploymentResolver:186/464
ConfigurationFactory:1554
BasicURLClassPath:83
ActiveMQ5Factory:409
Bug: https://issues.apache.org/jira/browse/TOMEE-1946