Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TOMEE-4113 - Update to MicroProfile Metrics 5 & SmallRye Metrics 5 #972

Merged
merged 54 commits into from
Apr 25, 2024

Conversation

jgallimore
Copy link
Contributor

No description provided.

…nd increase memory limit for remote TomEE server
@rzo1
Copy link
Contributor

rzo1 commented Jan 19, 2024

@jgallimore What do we need to do here?

@jgallimore
Copy link
Contributor Author

I'll take a look. I did quite a lot of work in this area, so it would be nice to get this over the line.

# Conflicts:
#	boms/tomee-microprofile/pom.xml
#	boms/tomee-plume/pom.xml
#	boms/tomee-plus/pom.xml
#	examples/mp-metrics-timed/pom.xml
#	pom.xml
#	tomee/tomee-microprofile/mp-common/pom.xml
#	tomee/tomee-microprofile/mp-common/src/main/java/org/apache/tomee/microprofile/TomEEMicroProfileListener.java
#	tomee/tomee-microprofile/mp-common/src/main/java/org/apache/tomee/microprofile/metrics/MPMetricsCDIExtension.java
@rzo1
Copy link
Contributor

rzo1 commented Feb 2, 2024

I just merged in the latest changes from main (from the last years). The Metrics TCK has only 3 failures :)

@tandraschko
Copy link
Member

did it pass before the upgrade? Otherwise lets merge and try to fix all TCKs after M1?

@rzo1
Copy link
Contributor

rzo1 commented Feb 2, 2024

did it pass before the upgrade? Otherwise lets merge and try to fix all TCKs after M1?

yes, it was ok ;-) (with 4.x)

@rzo1
Copy link
Contributor

rzo1 commented Apr 23, 2024

@jgallimore @tandraschko I expect the PR CI build to be green now, so we can move ahead with integrating this great PR into "main". TCK is passing (aside from 3 tests, which are optional) - therefore, I marked them as excluded (for now)

@rzo1 rzo1 merged commit bf0c7d2 into apache:main Apr 25, 2024
1 check passed
@rzo1
Copy link
Contributor

rzo1 commented Apr 25, 2024

Thanks @jgallimore - TCK for Metrics is good; some of the examples aren't compatible anymore which will be fixed with TOMEE-4329 - Fix Metrics examples to comply with Metrics 5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants