Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CID 1367523: (MISSING_MOVE_ASSIGNMENT): tsconfig/IntrusivePtr. #1284

Closed
zwoop opened this issue Dec 31, 2016 · 0 comments
Closed

CID 1367523: (MISSING_MOVE_ASSIGNMENT): tsconfig/IntrusivePtr. #1284

zwoop opened this issue Dec 31, 2016 · 0 comments
Labels

Comments

@zwoop
Copy link
Contributor

zwoop commented Dec 31, 2016

*** CID 1367523:    (MISSING_MOVE_ASSIGNMENT)
/lib/tsconfig/IntrusivePtr.h: 134 in ()
128         ownded by a set of pointers. When the last of the pointers is destructed
129         the target object is also destructed.
130     
131         The smart pointer actions can be changed through class specific policy
132         by specializing the @c IntrusivePtrPolicy template class.
133     */
   CID 1367523:    (MISSING_MOVE_ASSIGNMENT)
   Class "ts::IntrusivePtr<ts::Errata::Data>" may benefit from adding a move assignment operator. See other events which show the copy assignment operator being applied to rvalue(s), where a move assignment may be faster.
134     template <typename T> class IntrusivePtr : private IntrusivePtrBase
135     {
136     private:                          /* don't pollute client with these typedefs */
137       typedef IntrusivePtrBase super; ///< Parent type.
138       typedef IntrusivePtr self;      ///< Self reference type.
139     
/lib/tsconfig/IntrusivePtr.h: 134 in ()
128         ownded by a set of pointers. When the last of the pointers is destructed
129         the target object is also destructed.
130     
131         The smart pointer actions can be changed through class specific policy
132         by specializing the @c IntrusivePtrPolicy template class.
133     */
   CID 1367523:    (MISSING_MOVE_ASSIGNMENT)
   Class "ts::IntrusivePtr<ts::config::detail::ValueTableImpl>" may benefit from adding a move assignment operator. See other events which show the copy assignment operator being applied to rvalue(s), where a move assignment may be faster.
134     template <typename T> class IntrusivePtr : private IntrusivePtrBase
135     {
136     private:                          /* don't pollute client with these typedefs */
137       typedef IntrusivePtrBase super; ///< Parent type.
138       typedef IntrusivePtr self;      ///< Self reference type.
139     

@zwoop zwoop added the Coverity label Dec 31, 2016
@zwoop zwoop added this to the 7.1.0 milestone Dec 31, 2016
@zwoop zwoop modified the milestones: 7.1.0, 7.2.0 Jan 8, 2017
@PSUdaemon PSUdaemon modified the milestone: 7.2.0 Jan 8, 2017
@zwoop zwoop modified the milestones: 7.2.0, 8.0.0 Apr 25, 2017
@zwoop zwoop modified the milestone: 8.0.0 Jun 21, 2017
@zwoop zwoop closed this as completed Jun 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants