Skip to content
This repository has been archived by the owner on Jun 7, 2021. It is now read-only.

[TRAFODION-3215] length return 0 when the source and target charset is same #1719

Merged
merged 1 commit into from Oct 2, 2018

Conversation

Weixin-Xu
Copy link
Contributor

No description provided.

@Traf-Jenkins
Copy link

Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/3002/

@Traf-Jenkins
Copy link

@selvaganesang
Copy link
Contributor

+1.

  1. Ensure that surrounding code conventions like indentation are followed for easy reading.
  2. It will be good to create JIRA with symptom description rather than solution description. This would help consumers to pick up this PR if they encounter a similar problem. Otherwise, the consumers need to guess the PR to be picked up when they encounter a problem.

@Weixin-Xu
Copy link
Contributor Author

Actully, I use 4 blank and total 8 black but context use 2 tabs, so it seems different indentation.

@DaveBirdsall
Copy link
Contributor

Yeah, I've run into these indentation problems too. Best practice is to use blanks, not tabs, in new functions and methods. When I add lines within an existing method, I try to copy the white space from surrounding lines so if it has tabs it gets them and if it has blanks, it gets them instead. That tends to keep the appearance more uniform in the code.

It is a bother, though; perhaps someday we'll do a blanket replacement of all tabs with spaces and prevent new tabs from coming in.

@asfgit asfgit merged commit 71bf19d into apache:master Oct 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
5 participants