Skip to content
This repository has been archived by the owner on Jun 7, 2021. It is now read-only.

[TRAFODION-3246] add slf4j in jdbc #1757

Merged
merged 1 commit into from Dec 17, 2018
Merged

Conversation

mashengchen
Copy link
Contributor

add a new jar which can use slf4j to print log

@Traf-Jenkins
Copy link

Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/3057/

@Traf-Jenkins
Copy link

@DaveBirdsall
Copy link
Contributor

@arvind-narain, @hegdean , @svarnau: Any comments on this one?

@svarnau
Copy link
Contributor

svarnau commented Dec 10, 2018

This seems to be bundling in slf4j with JDBC driver. If that is the case, then the slf4j license, which is already in licenses/lic-server-bin needs to also be added to licenses/lic-clients-bin.

@mashengchen
Copy link
Contributor Author

thank you for your help Steve

@Traf-Jenkins
Copy link

New Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/3063/

@Traf-Jenkins
Copy link

@DaveBirdsall
Copy link
Contributor

@svarnau, does this look good to you now?

@@ -32,3 +32,30 @@ MIT like license. (http://site.icu-project.org/)
this Software without prior written authorization of the copyright holder.

===============================================================================
The binary distribution of Apache Trafodion DCS and REST components bundle
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here we should say JDBC driver instead of "DCS and REST components"

@Traf-Jenkins
Copy link

New Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/3065/

@Traf-Jenkins
Copy link

@mashengchen
Copy link
Contributor Author

is there some one can review this?

@DaveBirdsall
Copy link
Contributor

@svarnau, does this look good to you now?

@asfgit asfgit merged commit 17c28c6 into apache:master Dec 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
5 participants