[RFC] Use CMSIS-NN with TVM #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Minor nit - the title of the RFC should really read - [RFC] Use CMSIS-NN with TVM. @manupa-arm , @Mousius .. |
ashutosh-arm
changed the title
leandron
reviewed
Aug 6, 2021
leandron
approved these changes
Aug 6, 2021
Change-Id: I3b0954f3fdb4d54b3e38a84de0ab649c1e79bca8
Change-Id: I6142c001175cdf41c58b5bb555a39e07c834254f
Change-Id: Id63d1866cd783f5e59b568f36c9177ee8715bc4d
Change-Id: Id54bae4bd2ca4bd9c3ab734e8cae966ebbe332b2
comaniac
reviewed
Aug 9, 2021
There was a problem hiding this comment.
Overall LGTM. One thing I'm a little bit worry about is this RFC depends on another two RFCs (target hook and Ethos-U integration). I would be better if this RFC can also discuss the impact and alternative plan without other 2 RFCs so that this RFC won't be blocked.
areusch
reviewed
Aug 9, 2021
There was a problem hiding this comment.
@ashutosh-arm apologies for the delay! just a few points to clarify here.
Change-Id: I56a5f9bf319576d342a5bdc3771402262584e8c4
… with some terminologies Change-Id: I002be9cc67b72444ea27fe0a31769549fb6fd452
comaniac
reviewed
Aug 10, 2021
areusch
requested changes
Aug 10, 2021
There was a problem hiding this comment.
@ashutosh-arm i did another round here to clarify your intentions. i think this should be the bulk of my questions on this RFC
This was referenced Aug 24, 2021
areusch
approved these changes
Aug 28, 2021
|
Merging as Cody said LGTM in his last review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This RFC details integration of CMSIS-NN API into TVM to support code generation for Arm(R) Cortex-M using the following library: https://github.com/ARM-software/CMSIS_5/tree/develop/CMSIS/NN
cc : @areusch @mbaret @tqchen @Mousius @manupa-arm