Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inclusive Language RFC (#68) #68

Merged
merged 2 commits into from
May 11, 2022
Merged

Inclusive Language RFC (#68) #68

merged 2 commits into from
May 11, 2022

Conversation

grant-arm
Copy link
Contributor

This RFC proposes to:

  • Remove some non-inclusive language from the existing TVM codebase and documentation.
  • Introduce a linting script to CI that will prevent these non-inclusive terms from being re-introduced.

@Mousius @leandron @areusch

@grant-arm
Inclusive Language RFC (apache#68)
cf591dd 
This RFC proposes to:
* Remove some non-inclusive language from the existing TVM codebase and documentation.
* Introduce a linting script to CI that will prevent these non-inclusive terms from being re-introduced.

Change-Id: I17db86f1cdff6b3ab95bf5ed3bc20baffe212bcd
@grant-arm grant-arm mentioned this pull request May 6, 2022
Merged
junrushao
junrushao approved these changes May 7, 2022
View reviewed changes
Copy link
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 let's do that

@grant-arm
Inclusive Language RFC (apache#68)
1885026 
* Add text to explain the use of "blocklint: pragma"

Change-Id: I65e217d6c14fbdb9fc06f6b0ee4e83dc3c475a97
@leandron
Copy link
Contributor

leandron commented May 9, 2022

I think this is great. Let's leave the RFC open for a couple days more, in case anyone has anything to add, and then merge it.

@tmoreau89
Copy link

+1

1 similar comment
@Hzfengsy
Copy link
Member

+1

junrushao
junrushao approved these changes May 11, 2022
View reviewed changes
Copy link
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Mousius
Mousius approved these changes May 11, 2022
View reviewed changes
Copy link
Member

@Mousius Mousius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can consider this unanimously approved 😸

@Mousius Mousius merged commit 4203bd2 into apache:main May 11, 2022
@Mousius
Copy link
Member

Mousius commented May 11, 2022

Great work @grant-arm, a very positive initiative!

@mehrdadh
Copy link
Member

+1

@areusch
Copy link
Contributor

areusch commented May 11, 2022

sorry i'm behind on PRs, but I definitely support this effort!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leandron leandron leandron approved these changes

@Mousius Mousius Mousius approved these changes

@junrushao junrushao junrushao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@grant-arm @leandron @tmoreau89 @Hzfengsy @Mousius @mehrdadh @areusch @junrushao