Fix lint

apache · Nov 16, 2019 · 0a2c0cb · 0a2c0cb
1 parent f23de02
commit 0a2c0cb
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 6 deletions.
diff --git a/include/tvm/runtime/container.h b/include/tvm/runtime/container.h
@@ -44,7 +44,7 @@ class ADTObj : public Object {
    * \param idx The index of the element.
    * \return The ObjectRef at the index.
    */
-  ObjectRef operator [](size_t idx) const;
+  ObjectRef operator[](size_t idx) const;
 
   void* AddressOf(int i) const;
 

diff --git a/include/tvm/runtime/memory.h b/include/tvm/runtime/memory.h
@@ -77,8 +77,9 @@ class ObjAllocatorBase {
 
   /*!
    * \tparam T The type to be allocated.
+   * \tparam ElemType The type to array element.
    * \tparam Args The constructor signature.
-   * \param extra The size of extra space.
+   * \param num_elems The number of array elements.
    * \param args The arguments.
    */
   template<typename T, typename ElemType, typename... Args>

diff --git a/src/runtime/container.cc b/src/runtime/container.cc
@@ -29,7 +29,7 @@
 namespace tvm {
 namespace runtime {
 
-ObjectRef ADTObj::operator [](size_t idx) const {
+ObjectRef ADTObj::operator[](size_t idx) const {
   if (idx > this->size_) {
     LOG(FATAL) << "Index out of bound at " << idx << " bound is " << this->size_ << "\n";
   }
@@ -43,8 +43,6 @@ void* ADTObj::AddressOf(int i) const {
 }
 
 ADTObj::~ADTObj() {
-  ADTObj* self = const_cast<ADTObj*>(this);
-  Object* parent = static_cast<Object*>(self);
   for (size_t i = 0; i < size_; ++i) {
     ObjectRef* fp = reinterpret_cast<ObjectRef*>(AddressOf(i));
     fp->ObjectRef::~ObjectRef();

diff --git a/src/runtime/vm/object.cc b/src/runtime/vm/object.cc
@@ -80,7 +80,7 @@ TVM_REGISTER_GLOBAL("_vmobj.GetADTFields")
   const auto* cell = obj.as<ADTObj>();
   CHECK(cell != nullptr);
   CHECK_LT(idx, cell->size_);
-  *rv = cell->operator [](idx);
+  *rv = (*cell)[idx];
 });
 
 TVM_REGISTER_GLOBAL("_vmobj.Tensor")