Skip to content

Commit

Permalink
Updated TestTargetAutoParametrization
Browse files Browse the repository at this point in the history
When sorting the tests, the order of parametrizations may change.
Therefore, the tests checking for automatic target parametrization
shouldn't depend on order.
  • Loading branch information
Lunderberg committed Oct 6, 2021
1 parent 886f802 commit 41f8a48
Showing 1 changed file with 9 additions and 6 deletions.
15 changes: 9 additions & 6 deletions tests/python/unittest/test_tvm_testing_features.py
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,11 @@ def test_device_parametrization(self, dev):
self.devices_used.append(dev)

def test_all_targets_used(self):
assert self.targets_used == self.enabled_targets
assert self.devices_used == self.enabled_devices
assert sorted(self.targets_used) == sorted(self.enabled_targets)

def test_all_devices_used(self):
sort_key = lambda dev: (dev.device_type, dev.device_id)
assert sorted(self.devices_used, key=sort_key) == sorted(self.enabled_devices, key=sort_key)

targets_with_explicit_list = []

Expand All @@ -70,9 +73,9 @@ def test_exclude_target(self, target):
self.targets_with_exclusion.append(target)

def test_all_nonexcluded_targets_ran(self):
assert self.targets_with_exclusion == [
target for target in self.enabled_targets if not target.startswith("llvm")
]
assert sorted(self.targets_with_exclusion) == sorted(
[target for target in self.enabled_targets if not target.startswith("llvm")]
)

run_targets_with_known_failure = []

Expand All @@ -85,7 +88,7 @@ def test_known_failing_target(self, target):
assert "llvm" not in target

def test_all_targets_ran(self):
assert self.run_targets_with_known_failure == self.enabled_targets
assert sorted(self.run_targets_with_known_failure) == sorted(self.enabled_targets)

@tvm.testing.known_failing_targets("llvm")
@tvm.testing.parametrize_targets("llvm")
Expand Down

0 comments on commit 41f8a48

Please sign in to comment.