Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI Problem] python unit tests only run the cases in the arith folder #16510

Closed
liushengjiezj opened this issue Feb 2, 2024 · 3 comments
Closed
Labels
needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it type:ci Relates to TVM CI infrastructure

Comments

@liushengjiezj
Copy link

The ArmChina team recently synchronized the community's new code and found that python's unittest was split from one folder into multiple folders and traversed multiple folders to run in the bash script(tests/scripts/task_python_unittest.sh).
图片

But in line 57, we found that if the for statement is written like this, only the first element in the array will be looped. In other words, running this script will only run the test cases in the arith folder.

We found a recent pipeline to verify the behavior of this script, and indeed only the test cases in the arith folder were run:
https://ci.tlcpack.ai/blue/organizations/jenkins/tvm-cpu/detail/main/1311/pipeline/91/
图片

Is it intentional to write this way or are there other considerations?
@Hzfengsy @tqchen @Johnson9009

Branch/PR Failing

None

Jenkins Link

https://ci.tlcpack.ai/blue/organizations/jenkins/tvm-cpu/detail/main/1311/pipeline/91/

Flakiness

None

Triage

  • dev:test-infra
@liushengjiezj liushengjiezj added needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it type:ci Relates to TVM CI infrastructure labels Feb 2, 2024
@Johnson9009
Copy link
Contributor

@Hzfengsy We aren't sure if it is a bug, if it is a typo bug, I think we need fix it and check if the Unity branch transformation haven't run these tests too.

@Hzfengsy
Copy link
Member

Hzfengsy commented Feb 2, 2024

Thanks @liushengjiezj for finding this. It's a bug with no doubt and it fails even after the unity transition.

Could you please send a patch to fix it?

@Johnson9009
Copy link
Contributor

@liushengjiezj Please help to send a patch to change all these thing we find, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it type:ci Relates to TVM CI infrastructure
Projects
None yet
Development

No branches or pull requests

3 participants