Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI][FIX] Fix Typo Bug of For Loop Statement in Bash Script #16520

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[CI][FIX] Fix Typo Bug of For Loop Statement in Bash Script #16520

wants to merge 1 commit into from

Conversation

liushengjiezj
Copy link

@liushengjiezj liushengjiezj commented Feb 4, 2024 •
edited

Fix issue #16510
Please help to review this patch, thanks @Hzfengsy @Johnson9009

@liushengjiezj liushengjiezj marked this pull request as draft February 4, 2024 02:30
@liushengjiezj liushengjiezj marked this pull request as ready for review February 4, 2024 02:33
@Johnson9009
Copy link
Contributor

@tqchen @Hzfengsy It seems we need involve more resources to fix these failed cases.

@Hzfengsy
Copy link
Member

Hzfengsy commented Feb 5, 2024

Thanks for the PR. I'm working on the ut fix. I would open a new PR including:

  1. bash fix in this PR
  2. ut fixes to ensure all test pass

@Hzfengsy Hzfengsy mentioned this pull request Feb 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@liushengjiezj @Johnson9009 @Hzfengsy